This repository has been archived by the owner on Dec 1, 2021. It is now read-only.
errors: add a benchmark comparing stack trace performance #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice use of the new sub benchmark feature. 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cost is roughly 1600 ns to 6000 ns depending on the stack size. Adds two additional allocations.
BenchmarkErrors/pkg/errors-stack-10-4 1000000 1676 ns/op 320 B/op 3 allocs/op
BenchmarkErrors/errors-stack-10-4 20000000 64.9 ns/op 16 B/op 1 allocs/op
BenchmarkErrors/pkg/errors-stack-100-4 500000 3058 ns/op 320 B/op 3 allocs/op
BenchmarkErrors/errors-stack-100-4 3000000 472 ns/op 16 B/op 1 allocs/op
BenchmarkErrors/pkg/errors-stack-1000-4 200000 10685 ns/op 320 B/op 3 allocs/op
BenchmarkErrors/errors-stack-1000-4 300000 4523 ns/op 16 B/op 1 allocs/op
Fixes #72